spanconfigsubscriber: pass ctx to KVSubscriber callbacks#76311
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 10, 2022
Merged
Conversation
Member
|
This change is |
One of these callbacks, in store.go, was capturing a ctx and using it async. That was a tracing span use-after-finish. This patch fixes it by plumbing contexts and avoiding the capture. Release note: None
a5e973f to
14001c5
Compare
tbg
approved these changes
Feb 9, 2022
Member
tbg
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @irfansharif)
Contributor
Author
|
TFTRs! bors r+ |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of these callbacks, in store.go, was capturing a ctx and using it
async. That was a tracing span use-after-finish. This patch fixes it by
plumbing contexts and avoiding the capture.
Release note: None