Skip to content

server: add internal_app_name_prefix to ListSessionsResponse#76307

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
gtr:gtr-sessions-response
Feb 11, 2022
Merged

server: add internal_app_name_prefix to ListSessionsResponse#76307
craig[bot] merged 1 commit intocockroachdb:masterfrom
gtr:gtr-sessions-response

Conversation

@gtr
Copy link
Copy Markdown

@gtr gtr commented Feb 9, 2022 •
edited
Loading

Previously, the InternalAppNamePrefix constant from catconstants was
only included in the Statements Response. This change adds that same
field to the ListSessionsResponse.

Release note (API change): InternalAppNamePrefix added to ListSessionsResponse.

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Feb 9, 2022

This change is Reviewable

@gtr gtr requested review from a team and xinhaoz February 9, 2022 16:53
@gtr gtr force-pushed the gtr-sessions-response branch from 956c4ed to c640017 Compare February 9, 2022 19:26
@xinhaoz
Copy link
Copy Markdown
Contributor

xinhaoz commented Feb 9, 2022

pkg/server/serverpb/status.proto, line 823 at r1 (raw file):

  // If set and non-empty, indicates the prefix to application_name
  // used for statements/queries issued internally by CockroachDB.
  string internal_app_name_prefix = 4;

Any reason this field value is 4 and not 3?

@gtr gtr force-pushed the gtr-sessions-response branch from c640017 to 6fee634 Compare February 9, 2022 21:04
@gtr gtr requested a review from a team as a code owner February 9, 2022 21:04
@gtr gtr force-pushed the gtr-sessions-response branch from 6fee634 to 707cf36 Compare February 9, 2022 21:14
@gtr
Copy link
Copy Markdown
Author

gtr commented Feb 9, 2022

pkg/server/serverpb/status.proto, line 823 at r1 (raw file):

  // If set and non-empty, indicates the prefix to application_name
  // used for statements/queries issued internally by CockroachDB.
  string internal_app_name_prefix = 4;

Any reason this field value is 4 and not 3?

Good catch! Fixed it.

maryliag
maryliag reviewed Feb 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gtr and @xinhaoz)

-- commits, line 8 at r2:
you're adding a new value on the api, so there is a release note, in this case a "api change" one

@gtr gtr force-pushed the gtr-sessions-response branch from 707cf36 to 8298732 Compare February 10, 2022 14:47
@xinhaoz
Copy link
Copy Markdown
Contributor

xinhaoz commented Feb 10, 2022

pkg/server/status.go, line 2298 at r3 (raw file):

		Sessions:              make([]serverpb.Session, 0),
		Errors:                make([]serverpb.ListSessionsError, 0),
		InternalAppNamePrefix: catconstants.InternalAppNamePrefix,

Make sure to add this toListSessions response for tenants too (in tenant_status.go).

server: add internal_app_name_prefix to ListSessionsResponse
21dd242 
Previously, the InternalAppNamePrefix constant from catconstants was
only included in the Statements Response. This change adds that same
field to the ListSessionsResponse.

Release note: none
@gtr gtr force-pushed the gtr-sessions-response branch from 8298732 to 21dd242 Compare February 10, 2022 16:40
xinhaoz
xinhaoz approved these changes Feb 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@xinhaoz xinhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gtr, @maryliag, and @xinhaoz)

@gtr
Copy link
Copy Markdown
Author

gtr commented Feb 10, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 11, 2022

Build succeeded:

@craig craig bot merged commit c459d39 into cockroachdb:master Feb 11, 2022
@gtr gtr mentioned this pull request Feb 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@maryliag maryliag maryliag left review comments

@xinhaoz xinhaoz xinhaoz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gtr @cockroach-teamcity @xinhaoz @maryliag