Skip to content

backupccl: flip bulkio.backup.split_keys_on_timestamps to true#76254

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
adityamaru:switch-on-export-pagination
Feb 9, 2022
Merged

backupccl: flip bulkio.backup.split_keys_on_timestamps to true#76254
craig[bot] merged 1 commit intocockroachdb:masterfrom
adityamaru:switch-on-export-pagination

Conversation

@adityamaru
Copy link
Copy Markdown
Contributor

@adityamaru adityamaru commented Feb 8, 2022

Release note (sql change): Release note (sql change): BACKUPs of ranges containing extremely
large numbers of revisions to a single row no longer fail with
errors related to exceeding size limit.

@adityamaru adityamaru requested review from a team, aliher1911 and dt February 8, 2022 20:13
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@adityamaru
Copy link
Copy Markdown
Contributor Author

Going to let CI shake out any failures.

@dt
Copy link
Copy Markdown
Contributor

dt commented Feb 9, 2022

nit: release note should be written for end-user consumption, e.g. "BACKUPs of ranges containing extremely large numbers of revisions to a single row no longer fail with errors related to exceeding size limit"

Release note (sql change): BACKUPs of ranges containing extremely
large numbers of revisions to a single row no longer fail with
errors related to exceeding size limit.
@adityamaru adityamaru force-pushed the switch-on-export-pagination branch from 763213c to 532570d Compare February 9, 2022 14:12
@adityamaru
Copy link
Copy Markdown
Contributor Author

TFTR!

bors r=dt

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 9, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 9, 2022

Build succeeded:

@craig craig bot merged commit 90629ae into cockroachdb:master Feb 9, 2022
@adityamaru adityamaru deleted the switch-on-export-pagination branch February 9, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants