tree: remove TODOs about bytea/float cast volatility#76194
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 8, 2022
Merged
tree: remove TODOs about bytea/float cast volatility#76194craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
These comments aren't needed, since the current cast volatility is correct, as far as I can tell. We might want to report this as a bug in Postgres if it describes these casts as immutable incorrectly. Release note: None
Member
|
This change is |
mgartner
approved these changes
Feb 7, 2022
Contributor
mgartner
left a comment
There was a problem hiding this comment.
Thanks! This does look like a bug in Postgres. I'll report it.
Collaborator
Author
|
bors r=mgartner |
Collaborator
Author
|
tftr! and for reporting it to them |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
Contributor
|
Reported to Postgres here: https://www.postgresql.org/message-id/17398-8fb0c02a60e2e565%40postgresql.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These comments aren't needed, since the current cast volatility is
correct, as far as I can tell.
We might want to report this as a bug in Postgres if it describes these
casts as immutable incorrectly.
Release note: None