sql: test ON UPDATE's interaction with backfills over row#75846
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 3, 2022
Merged
sql: test ON UPDATE's interaction with backfills over row#75846craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ded71aa to
d52a656
Compare
otan
reviewed
Feb 2, 2022
| ALTER TYPE test_enum DROP VALUE 'y' | ||
|
|
||
| # Interaction with backfills over row | ||
| subtest SimpleUsage |
Contributor
There was a problem hiding this comment.
maybe subtest test_on_update_backfill
| statement error pq: could not remove enum value "y" as it is being used in an ON UPDATE expression of "test_array_enum" | ||
| ALTER TYPE test_enum DROP VALUE 'y' | ||
|
|
||
| # Interaction with backfills over row |
Contributor
There was a problem hiding this comment.
let's make the comment "Tests adding new columns will not trigger the ON UPDATE clause."
Fixes cockroachdb#69058 Release Note: none
d52a656 to
3ffb164
Compare
otan
approved these changes
Feb 2, 2022
Collaborator
Author
|
Thanks! |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69058
Release Note: none