Skip to content

sql: add the TTL automatic column & related variables#75779

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
otan-cockroach:auto_col
Feb 3, 2022
Merged

sql: add the TTL automatic column & related variables#75779
craig[bot] merged 2 commits intocockroachdb:masterfrom
otan-cockroach:auto_col

Conversation

@otan
Copy link
Copy Markdown
Contributor

@otan otan commented Feb 1, 2022

See individual commits for details.

@otan otan requested a review from rafiss February 1, 2022 09:16
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

otan added 2 commits February 3, 2022 07:31
Aligning with the RFC a bit more, we're also implicitly adding the `ttl`
and `ttl_automatic_column` session variables to SHOW CREATE TABLE. Later
this can be used to unset the TTL state.

These are placeholders for now that make `SHOW CREATE TABLE` show the
create output and have the same `SHOW CREATE TABLE` statement replayable
into the DB.

Release note: None
@otan otan marked this pull request as ready for review February 2, 2022 20:50
@otan otan requested a review from a team February 2, 2022 20:50
Copy link
Copy Markdown

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Feb 3, 2022

thanks ❤️

bors r=postamar

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 3, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 3, 2022

Build succeeded:

@craig craig bot merged commit f20c1a8 into cockroachdb:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants