Skip to content

roachtest/follower_reads: unskip follower-reads/mixed-version/single-region#75738

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
andreimatei:small.unskip-follower
Feb 8, 2022
Merged

roachtest/follower_reads: unskip follower-reads/mixed-version/single-region#75738
craig[bot] merged 1 commit intocockroachdb:masterfrom
andreimatei:small.unskip-follower

Conversation

@andreimatei
Copy link
Copy Markdown
Contributor

It should have been unskipped with the rest of the follower reads tests
when #69817 was closed.

Release note: None

…region

It should have been unskipped with the rest of the follower reads tests
when cockroachdb#69817 was closed.

Release note: None
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@aayushshah15 aayushshah15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@aayushshah15
Copy link
Copy Markdown
Contributor

Do we not want to merge this patch yet?

Copy link
Copy Markdown
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r_

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Copy link
Copy Markdown
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@andreimatei
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 7, 2022

Build failed (retrying...):

@craig craig bot merged commit 8ec5bf1 into cockroachdb:master Feb 8, 2022
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 8, 2022

Build succeeded:

@andreimatei andreimatei deleted the small.unskip-follower branch February 8, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants