bench/rttanalysis: skip the first iteration, take average#75599
Merged
jlinder merged 1 commit intocockroachdb:masterfrom Jan 27, 2022
Merged
bench/rttanalysis: skip the first iteration, take average#75599jlinder merged 1 commit intocockroachdb:masterfrom
jlinder merged 1 commit intocockroachdb:masterfrom
Conversation
We've had some flakes lately. One hypothesis I had was that we were seeing a restart. Indeed when I added an extra iteration, it shook out the numbers we were seeing. I didn't dig very deeply. I imagine there's something interesting there. However, I just want stable tests. Fixes cockroachdb#74396 Release note: None
Member
|
This change is |
stevendanna
approved these changes
Jan 27, 2022
Collaborator
stevendanna
left a comment
There was a problem hiding this comment.
Seems reasonable to me, thanks for keeping on top of these.
Contributor
Author
|
TFTR bors r+ |
Contributor
|
Build failed (retrying...): |
Collaborator
|
bors r- |
Contributor
|
Canceled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had some flakes lately. One hypothesis I had was that we were seeing a
restart. Indeed when I added an extra iteration, it shook out the numbers we
were seeing. I didn't dig very deeply. I imagine there's something interesting
there. However, I just want stable tests.
Fixes #74396
Release note: None