ui: removed formatting to statements on the details pages#75443
ui: removed formatting to statements on the details pages#75443craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
|
This change is |
Previously, all statements were formatted prior to being sent to the frontend. However, the formatting was causing statements queries from the frontend to run noticeably more slowly. This change removes the logic that formats all queries, but keeps the addition of the new builtin function prettify_statement. Release note (sql change): statements are no longer formatted prior to being sent to the UI, but the new builtin function remains.
Previously, statements displayed on the statement/transaction/index details pages were formatted (formatting was added to allow for better readability of statements on these detail pages). However, statements queries from the frontend were noticeably slower due to this implementation. This change reverts the changes to statement formatting (updates the fixtures to show the non-formatted statements), but keeps the change that uses statement ID as an identifier in the URL instead of the raw statement. Release note (ui change): removed formatting to statements on the statement, transaction and index details pages, change to replace raw statement with statement ID in the URL remained.
ab2b429 to
39604d8
Compare
maryliag
left a comment
There was a problem hiding this comment.
Thanks for making those changes!
Reviewable status:
complete! 1 of 0 LGTMs obtained
|
bors r+ |
|
blathers backport 21.2 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from c02b3b1 to blathers/backport-release-21.2-75443: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from c02b3b1 to blathers/backport-release-21.2-75443: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
ui: removed formatting to statements on the details pages
Previously, statements displayed on the statement/transaction/index
details pages were formatted (formatting was added to allow for better
readability of statements on these detail pages). However, statements
queries from the frontend were noticeably slower due to this
implementation. This change reverts the changes to statement formatting
(updates the fixtures to show the non-formatted statements), but keeps
the change that uses statement ID as an identifier in the URL instead of
the raw statement.
Reference: Original PR
Release note (ui change): change to replace raw
statement with statement ID in the URL.