catalog: add Index.InvertedColumnKeyType#75427
Conversation
|
This change is |
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @rytaft)
pkg/sql/catalog/table_elements.go, line 157 at r1 (raw file):
// InvertedColumnID returns the ColumnID of the inverted column of the // inverted index. InvertedColumnID() descpb.ColumnID
Comment about the panic if it's not an inverted index
pkg/sql/catalog/table_elements.go, line 161 at r1 (raw file):
// InvertedColumnName returns the name of the inverted column of the inverted // index. InvertedColumnName() string
Comment about the panic if it's not an inverted index
pkg/sql/catalog/table_elements.go, line 165 at r1 (raw file):
// InvertedColumnKeyType returns the type of the data element that is encoded // as the inverted index key. This is currently always Bytes. InvertedColumnKeyType() *types.T
Comment about the panic if it's not an inverted index
|
rebase to fix the flake |
In an inverted index, the encoded key is treated as a Bytes datum. This is currently hardcoded in the opt catalog. This commit moves this into the index descriptor. Release note: None
948765b to
dee8e2b
Compare
RaduBerinde
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
RaduBerinde
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
|
TFTRs! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
In an inverted index, the encoded key is treated as a Bytes datum.
This is currently hardcoded in the opt catalog.
This commit moves this into the index descriptor.
Release note: None