partitionccl,logictestccl: rewrite flaky test#75300
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 23, 2022
Merged
partitionccl,logictestccl: rewrite flaky test#75300craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
1eabfcb to
ae88e4b
Compare
andreimatei
reviewed
Jan 21, 2022
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
I've only glossed over the test, but 
Reviewable status:
complete! 1 of 0 LGTMs obtained
fqazi
approved these changes
Jan 21, 2022
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
The test in question would flake if the drop index job ran to completion before the type change ran. This was flakey. We instead make it a real go test and use a testing knob to prevent this from happening. Fixes cockroachdb#68395 Release note: None
ae88e4b to
8d5c2d3
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This was referenced Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test in question would flake if the drop index job ran to completion
before the type change ran. This was flakey. We instead make it a real go test
and use a testing knob to prevent this from happening.
Fixes #68395
Release note: None