Skip to content

cmd/github-post: fix Pebble metamorphic reproduction command#75215

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:pebble-meta-ops
Jan 21, 2022
Merged

cmd/github-post: fix Pebble metamorphic reproduction command#75215
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:pebble-meta-ops

Conversation

@jbowens
Copy link
Copy Markdown
Contributor

@jbowens jbowens commented Jan 20, 2022

When posting a github issue for a Pebble metamorphic test failure, include the
correct -ops flag.

Discovered because cockroachdb/pebble#1459 contained a
reproduction command that contained too few ops to reproduce the issue.

Release note: none

@jbowens jbowens requested review from a team and nicktrav January 20, 2022 15:38
@jbowens jbowens requested review from a team as code owners January 20, 2022 15:38
@jbowens jbowens requested review from stevendanna and removed request for a team January 20, 2022 15:38
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @nicktrav and @stevendanna)

Copy link
Copy Markdown
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)

When posting a github issue for a Pebble metamorphic test failure, include the
correct `-ops` flag.

Release note: none
@jbowens
Copy link
Copy Markdown
Contributor Author

jbowens commented Jan 20, 2022

TFTRs!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 21, 2022

Build succeeded:

@craig craig bot merged commit 488a06b into cockroachdb:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants