security,*: extend CheckPasswordHashValidity to return a GH issue number (scram 1/10)#74841
Merged
craig[bot] merged 1 commit intomasterfrom Jan 21, 2022
Merged
security,*: extend CheckPasswordHashValidity to return a GH issue number (scram 1/10)#74841craig[bot] merged 1 commit intomasterfrom
craig[bot] merged 1 commit intomasterfrom
Conversation
Member
|
This change is |
rafiss
approved these changes
Jan 14, 2022
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @cameronnunez and @knz)
pkg/sql/create_role.go, line 268 at r1 (raw file):
var isPreHashed, schemeSupported bool var schemeName string var issueLink int
nit: this could be named issueNum also
knz
commented
Jan 15, 2022
Contributor
Author
knz
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/create_role.go, line 268 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
nit: this could be named issueNum also
Done.
rafiss
approved these changes
Jan 17, 2022
Contributor
Author
|
NB: I'm holding off merging this PR until all the PRs in the sequence are ready (otherwise, the entire chain will be auto-closed by github). |
2e15fac to
e78e1a3
Compare
This makes it clear what is not supported if the user requires a md5 hash. Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(PR peeled away from #74301; next PR in series: #74842)
This makes it clear what is not supported if the user requires a md5 hash.
Release note: None