colexec: operate on pointer to apd.Decimal rather than value#74469
Closed
yuzefovich wants to merge 5 commits intocockroachdb:masterfrom
Closed
colexec: operate on pointer to apd.Decimal rather than value#74469yuzefovich wants to merge 5 commits intocockroachdb:masterfrom
yuzefovich wants to merge 5 commits intocockroachdb:masterfrom
Conversation
When we introduced the hash aggregation with partial order support, we mistakenly removed the ordered aggregation from `aggTypes` slice that is used in some tests as well as in the benchmarks. This is now fixed. Release note: None
This commit removes a couple of `execgen.COPYVAL` calls that were redundant because the first and the second argument are the same. These calls are redundant because we already performed the same call right after calling `Get` from the original vector and we will perform a deep copy when calling `Set` next. Release note: None
This commit reduces the size of the hash aggregates by removing the reference to the well-typed column (i.e. a concrete unwrapped `coldata.Vec`, something like `[]int64`). This is possible because the hash aggregates only access the concrete column once, in `Flush`, so there is no point in storing the concrete column as we do for the ordered aggregates. We still perform the interface dispatch call only once - previously it was in `SetOutput`, now it is in `Flush`. This should be a non-trivial improvement since the hash aggregation uses a separate aggregation function object for each bucket. This change also allows us to remove the overriding of `SetOutput` method implimentation provided by the base struct from the hash and window aggregates. Release note: None
This commit removes some of the slice element assignments of the form `col[idx] = ...` in favor of its equivalent `col.Set(idx, ...)`. This makes it easier to change the type of the element. Release note: None
Member
To be filled if necessary. Release note: None
1784551 to
4a1fea3
Compare
Member
Author
|
This is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.