Skip to content

pgwire: retrieve password credentials concurrently with client wait#74365

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20211131-async-pw
Jan 4, 2022
Merged

pgwire: retrieve password credentials concurrently with client wait#74365
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20211131-async-pw

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Dec 31, 2021

Release note (performance improvement): CockroachDB now retrieves
the password credentials of the SQL client concurrently with waiting
for the password response during the authentication exchange.
This can yield a small latency reduction in new SQL connections.

Release note (performance improvement): CockroachDB now retrieves
the password credentials of the SQL client concurrently with waiting
for the password response during the authentication exchange.
This can yield a small latency reduction in new SQL connections.
@knz knz requested a review from rafiss December 31, 2021 15:56
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Dec 31, 2021

cc @jeffswenson FYI

Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @knz)

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Jan 4, 2022

TFYR!

bors r=rafiss

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 4, 2022

Build succeeded:

@craig craig bot merged commit 798a3e5 into cockroachdb:master Jan 4, 2022
@knz knz deleted the 20211131-async-pw branch January 4, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants