sql: don't formatStatementHideConstants when profiling prepared stmt#74351
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 4, 2022
Merged
Conversation
This commit removes the call to `formatStatementHideConstants` when executing a prepared statement while CPU profiling is enabled. The formatted statement is already available, so there's no need to re-format. Formatting isn't excessively expensive and we do expect CPU profiling to be disruptive, so the cost wasn't a big deal on its own. However, the more important part of the change is that it helps clean up the CPU profiles and make them more representative.
Member
|
This change is |
rafiss
approved these changes
Jan 4, 2022
Contributor
Author
|
TFTR! bors r=rafiss |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the call to
formatStatementHideConstantswhenexecuting a prepared statement while CPU profiling is enabled. The
formatted statement is already available, so there's no need to
re-format.
Formatting isn't excessively expensive and we do expect CPU profiling to
be disruptive, so the cost wasn't a big deal on its own. However, the
more important part of the change is that it helps clean up the CPU
profiles and make them more representative.