rpc: better logging for network latency changes#74312
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Dec 29, 2021
Merged
rpc: better logging for network latency changes#74312craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
it creates additional logging for latency hiccups. A warning is now emitted on the HEALTH channel whenever the RPC roundtrip heartbeat latency exceeds its latest moving average by 50%. Example output: ``` [n7,rnode=2,raddr=127.0.0.1:32341,class=default,heartbeat] 6721 latency jump (prev avg 28.86ms, current 48.56ms) ``` Release note: None
…hold Previously, clock latencies would log if they exceed 150% of the running average. This would log many times if latency remains in excess of that threshold (until the average rises), or if latency alternates from slightly above to slightly below the threshold from noise. This change logs once when latency exceeds 150% of the moving average and will not log again until it drops below 140% of the moving average. Release note: None
Member
|
This change is |
knz
approved these changes
Dec 29, 2021
Contributor
knz
left a comment
There was a problem hiding this comment.
LGTM
@erikgrinaker are you interested to have a quick look too?
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rauchenstein)
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
Contributor
|
Looks good, thanks! Would there be any value in making this configurable via a cluster setting? Although I suppose we can see how it behaves in the wild first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic: CRDB-11517
See individual commits for details.