roachpb: InternalServer API for tenant settings#74268
roachpb: InternalServer API for tenant settings#74268craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
|
Friendly ping. |
ajwerner
left a comment
There was a problem hiding this comment.
High level LGTM
Reviewed 1 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt and @RaduBerinde)
pkg/roachpb/api.proto, line 2631 at r1 (raw file):
// server side (e.g. to make it maintain very little state per tenant). message TenantSettingsEvent { // Tier indicates the tier and is either 1 or 2.
Any interest in a gogoproto.casttype?
Code quote:
// Tier indicates the tier and is either 1 or 2.
uint32 tier = 1;pkg/roachpb/api.proto, line 2646 at r1 (raw file):
// Overrides contains: // - all current setting overrides for the given tier if Incremental is // false; or
nit: trailing spaces
09705e6 to
36d2fdc
Compare
RaduBerinde
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/roachpb/api.proto, line 2631 at r1 (raw file):
Previously, ajwerner wrote…
Any interest in a
gogoproto.casttype?
Good idea, done. While writing this I also thought about whether precedence would be more descriptive than tier.
36d2fdc to
906d783
Compare
906d783 to
63fd95f
Compare
RaduBerinde
left a comment
There was a problem hiding this comment.
I like "precedence" too
Done! TFTR!
Reviewable status:
pkg/roachpb/api.proto, line 2651 at r5 (raw file):
// fields). repeated TenantSetting overrides = 3;
Moved this error field, I must have put it inside TenantSetting by accident.
ajwerner
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/roachpb/api.proto, line 2631 at r1 (raw file):
Previously, RaduBerinde wrote…
Good idea, done. While writing this I also thought about whether
precedencewould be more descriptive thantier.
Also +1 on precedence
This commit introduces the API that the tenants will use to obtain and list for updates to tenant setting overrides. The API was designed to allow for maximum flexibility on the server side so that it can be implemented as a range feed without any extra state (if necessary). Release note: None
63fd95f to
024cb0e
Compare
|
bors r+ |
|
Build succeeded: |
This commit introduces the API that the tenants will use to obtain and
list for updates to tenant setting overrides. The API was designed to
allow for maximum flexibility on the server side so that it can be
implemented as a range feed without any extra state (if necessary).
Release note: None