sql: use virtual column for hash sharded index#74138
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 21, 2021
Merged
sql: use virtual column for hash sharded index#74138craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
fixes cockroachdb#61564 This pr sets `Virtual=True` for shard column when creating a hash sharded index. The shard column won't be in any column family since it's virtual. Release note (sql change): Shard column of hash sharded index is now a virtual column instead of stored.
e8ffa2b to
91113b0
Compare
ajwerner
approved these changes
Dec 21, 2021
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @postamar)
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #61564
This pr sets
Virtual=Truefor shard column when creating ahash sharded index. The shard column won't be in any column
family since it's virtual.
Release note (sql change): Shard column of hash sharded index
is now a virtual column instead of stored.