bazel: require setting cockroach_cross=y to opt into cross toolchains#74110
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 21, 2021
Merged
Conversation
With `--incompatible_enable_cc_toolchain_resolution` set in cockroachdb#73819, now Bazel selects the appropriate toolchain for you. Bazel was selecting the `cross_linux_toolchain` when building for the host platform on Linux, resulting in link errors when trying to compile `stress` under `race`. We update the toolchains to instead require opting into the cross toolchains by defining `cockroach_cross=y`. Closes cockroachdb#73997. Release note: None
Member
|
This change is |
irfansharif
approved these changes
Dec 21, 2021
Collaborator
Author
|
bors r=irfansharif |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--incompatible_enable_cc_toolchain_resolutionset in #73819, nowBazel selects the appropriate toolchain for you. Bazel was selecting the
cross_linux_toolchainwhen building for the host platform on Linux,resulting in link errors when trying to compile
stressunderrace.We update the toolchains to instead require opting into the cross
toolchains by defining
cockroach_cross=y.Closes #73997.
Release note: None