bazel: expose devdarwinx86_64 toolchain via platform rules#73982
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 17, 2021
Merged
bazel: expose devdarwinx86_64 toolchain via platform rules#73982craig[bot] merged 1 commit intocockroachdb:masterfrom
devdarwinx86_64 toolchain via platform rules#73982craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This becomes necessary after cockroachdb#73819, which sets `--incompatible_enable_cc_toolchain_resolution` for builds. The problem is that this flag causes Bazel to ignore `--crosstool_top` in favor of what toolchain it selects via [toolchain resolution](https://docs.bazel.build/versions/main/toolchains.html#toolchain-resolution). Therefore we update `.bazelrc` to specify the `--platforms` instead of `--crosstool_top`, and add an appropriate `toolchain` in `build/toolchains`. Release note: None
Member
|
This change is |
irfansharif
approved these changes
Dec 17, 2021
Contributor
|
Thanks Ricky! |
Collaborator
Author
|
bors r=irfansharif |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This becomes necessary after #73819, which sets
--incompatible_enable_cc_toolchain_resolutionfor builds. The problemis that this flag causes Bazel to ignore
--crosstool_topin favor ofwhat toolchain it selects via toolchain resolution.
Therefore we update
.bazelrcto specify the--platformsinstead of--crosstool_top, and add an appropriatetoolchaininbuild/toolchains.Release note: None