Skip to content

sqlsmith: don't compare voids for joins#73954

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
otan-cockroach:void_fix
Dec 17, 2021
Merged

sqlsmith: don't compare voids for joins#73954
craig[bot] merged 2 commits intocockroachdb:masterfrom
otan-cockroach:void_fix

Conversation

@otan
Copy link
Copy Markdown
Contributor

@otan otan commented Dec 17, 2021

No comparison expr is defined on voids, so don't generate comparisons
for them.

Resolves #73901
Resolves #73898
Resolves #73777

Release note: None

No comparison expr is defined on voids, so don't generate comparisons
for them.

Release note: None
@otan otan requested a review from rafiss December 17, 2021 00:23
@otan otan requested a review from a team as a code owner December 17, 2021 00:23
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Dec 17, 2021

bors r=rafiss

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 17, 2021

Canceled.

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Dec 17, 2021

bors r=rafiss

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 17, 2021

Canceled.

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Dec 17, 2021

bors r=rafiss

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 17, 2021

Build succeeded:

@craig craig bot merged commit 089affc into cockroachdb:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants