DOC-2096: Update diagrams.go to force scrolling on svg div blocks#73948
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 17, 2021
nickvigilante:DOC-2096-crdb
Merged
DOC-2096: Update diagrams.go to force scrolling on svg div blocks#73948craig[bot] merged 1 commit intocockroachdb:masterfrom nickvigilante:DOC-2096-crdb
craig[bot] merged 1 commit intocockroachdb:masterfrom
nickvigilante:DOC-2096-crdb
Conversation
Member
|
This change is |
ericharmeling
approved these changes
Dec 17, 2021
ericharmeling
left a comment
There was a problem hiding this comment.
LGTM! Just tested the changes locally, and all SVGs generated exactly as they should.
IDK why the Bazel test is failing though. Maybe try rebasing on master and force-pushing to your fork branch? It should kick off the tests again.
Release note: None
Contributor
Author
|
@ericharmeling Can you bors this for me? Engineering doesn't let non-engineers use bors anymore. |
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: None