ccl/sqlproxyccl: fix TestWatchPods under stressrace#73946
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 17, 2021
Merged
ccl/sqlproxyccl: fix TestWatchPods under stressrace#73946craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes cockroachdb#69220. Regression from cockroachdb#67452. In cockroachdb#67452, we omitted DRAINING pods from the tenant directory. Whenever a pod goes into the DRAINING state, the pod watcher needs time to update the directory. Not waiting for that while calling EnsureTenantAddr produces a stale result. This commit updates TestWatchPods by polling on EnsureTenantAddr until that has been completed. Release note: None
Member
|
This change is |
jaylim-crl
commented
Dec 16, 2021
Contributor
Author
jaylim-crl
left a comment
There was a problem hiding this comment.
See #69220 (comment) for more info.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andy-kimball)
andy-kimball
approved these changes
Dec 16, 2021
Contributor
andy-kimball
left a comment
There was a problem hiding this comment.
Reviewable status:
jaylim-crl
commented
Dec 16, 2021
Contributor
Author
jaylim-crl
left a comment
There was a problem hiding this comment.
TFTRs!
Reviewable status:
jaylim-crl
commented
Dec 17, 2021
Contributor
Author
jaylim-crl
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69220.
Regression from #67452.
In #67452, we omitted DRAINING pods from the tenant directory. Whenever a pod
goes into the DRAINING state, the pod watcher needs time to update the
directory. Not waiting for that while calling EnsureTenantAddr produces a
stale result. This commit updates TestWatchPods by polling on EnsureTenantAddr
until the pod watcher updates the directory.
Release note: None