sql: simplify inserts into database descs with empty schemas map#73942
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 17, 2021
Merged
Conversation
Member
ajwerner
approved these changes
Dec 16, 2021
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msbutler, @postamar, and @RichardJCai)
pkg/sql/catalog/dbdesc/database_desc.go, line 483 at r1 (raw file):
// AddSchemaToDatabase adds a schemaName and schemaInfo entry into the // database's Schemas map. If the map is nil, then we create a map before // adding the entry.
comment that if there is already an entry, it will be overwritten
Code quote:
// database's Schemas map. If the map is nil, then we create a map before
// adding the entry.
Collaborator
|
LGTM from the bulk side! |
msbutler
approved these changes
Dec 16, 2021
Release note: None
73196d3 to
66ce0ce
Compare
Contributor
Author
|
Thanks! |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: None