Skip to content

sql: simplify inserts into database descs with empty schemas map#73942

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
RichardJCai:simplify_inserts_into_empty_database_schemas_map
Dec 17, 2021
Merged

sql: simplify inserts into database descs with empty schemas map#73942
craig[bot] merged 1 commit intocockroachdb:masterfrom
RichardJCai:simplify_inserts_into_empty_database_schemas_map

Conversation

@RichardJCai
Copy link
Copy Markdown
Contributor

Release note: None

@RichardJCai RichardJCai requested review from a team, ajwerner, msbutler and postamar and removed request for a team December 16, 2021 21:06
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @msbutler, @postamar, and @RichardJCai)


pkg/sql/catalog/dbdesc/database_desc.go, line 483 at r1 (raw file):

// AddSchemaToDatabase adds a schemaName and schemaInfo entry into the
// database's Schemas map. If the map is nil, then we create a map before
// adding the entry.

comment that if there is already an entry, it will be overwritten

Code quote:

// database's Schemas map. If the map is nil, then we create a map before
// adding the entry.

@msbutler
Copy link
Copy Markdown
Collaborator

LGTM from the bulk side!

@RichardJCai RichardJCai force-pushed the simplify_inserts_into_empty_database_schemas_map branch from 73196d3 to 66ce0ce Compare December 17, 2021 01:35
@RichardJCai
Copy link
Copy Markdown
Contributor Author

Thanks!
bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 17, 2021

Build succeeded:

@craig craig bot merged commit 52b398f into cockroachdb:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants