ui: select grants tab on table details page#73932
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 17, 2021
Merged
ui: select grants tab on table details page#73932craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Previosuly, when the grants view was selected on the Database Details page, it was going to the Table Details with the Overview tab selected. With this commit, if the view mode selected is Grant, the grant tab is selected on the Table Details page. Fixes cockroachdb#68829 Release note: None
lindseyjin
approved these changes
Dec 16, 2021
Contributor
lindseyjin
left a comment
There was a problem hiding this comment.
Tested locally, and LGTM!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @lindseyjin)
pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx, line 306 at r1 (raw file):
]; render(): React.ReactElement {
Btw, what does this do? Are you just adding in the type?
maryliag
commented
Dec 16, 2021
Contributor
Author
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx, line 306 at r1 (raw file):
Previously, lindseyjin (Lindsey Jin) wrote…
Btw, what does this do? Are you just adding in the type?
Is just showing what is the return type for the function, in this case a React Element :)
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previosuly, when the grants view was selected on the Database
Details page, it was going to the Table Details with the Overview
tab selected.
With this commit, if the view mode selected is Grant, the grant
tab is selected on the Table Details page.
Fixes #68829
Release note: None