Skip to content

envutil: avoid importing testing in non-test code#73905

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20211216-tb
Dec 16, 2021
Merged

envutil: avoid importing testing in non-test code#73905
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20211216-tb

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Dec 16, 2021

Thanks to @dt for noticing.

Release note: None

@knz knz requested review from dt and jeffswenson December 16, 2021 10:22
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@dt dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for fixing this.

Thanks to @dt for noticing.

Release note: None
@knz
Copy link
Copy Markdown
Contributor Author

knz commented Dec 16, 2021

bors r=dt,JeffSwenson

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 16, 2021

Build succeeded:

@craig craig bot merged commit db6851b into cockroachdb:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants