Skip to content

*: enable span configs by default#73876

Merged
craig[bot] merged 7 commits intocockroachdb:masterfrom
irfansharif:211214.enable-spanconfigs
Jan 18, 2022
Merged

*: enable span configs by default#73876
craig[bot] merged 7 commits intocockroachdb:masterfrom
irfansharif:211214.enable-spanconfigs

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

@irfansharif irfansharif commented Dec 15, 2021

We were previously using an opt-in flag to enable span configs; this
commit flips it into an opt-out one. This has the following effects:

  • fresh crdb nodes/clusters run with span configs enabled.
  • our entire test suite runs using the span configs infrastructure, save
    for a select few written:
    • with the gossipped system config span in mind;
    • using legacy testing harnesses that prevent injection of
      spanconfig dependencies due to circular imports.

We also introduce a more minified form of the opt-out testing flag:
UseSystemConfigSpanForQueues. Using the minified form still enables the
SQL-side of span configs to run (Reconciler, SQLWatcher, SQLTranslator)
but defaults to using the system config span down in KV.

Release note: None

@irfansharif irfansharif requested review from a team as code owners December 15, 2021 22:45
@irfansharif irfansharif requested review from a team, erikgrinaker, samiskin and tbg and removed request for a team, samiskin and tbg December 15, 2021 22:45
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@irfansharif irfansharif removed the request for review from erikgrinaker December 15, 2021 22:45
@tbg
Copy link
Copy Markdown
Member

tbg commented Dec 16, 2021

Heads up, you can use draft PRs to avoid sending out emails.

@tbg tbg marked this pull request as draft December 16, 2021 08:37
@irfansharif irfansharif force-pushed the 211214.enable-spanconfigs branch 3 times, most recently from a24c292 to 61125e5 Compare December 21, 2021 01:11
@irfansharif irfansharif force-pushed the 211214.enable-spanconfigs branch from 4214d8a to 8b4b2b5 Compare December 22, 2021 03:35
@irfansharif irfansharif changed the title [wip] *: enable span configs infrastructure by default *: enable span configs infrastructure by default Dec 22, 2021
@irfansharif irfansharif marked this pull request as ready for review December 22, 2021 03:43
@irfansharif irfansharif requested a review from a team December 22, 2021 03:43
@irfansharif irfansharif requested review from a team as code owners December 22, 2021 03:43
@irfansharif irfansharif requested a review from a team December 22, 2021 03:43
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 18, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants