*: enable span configs by default#73876
Merged
craig[bot] merged 7 commits intocockroachdb:masterfrom Jan 18, 2022
Merged
Conversation
Member
24 tasks
Member
|
Heads up, you can use draft PRs to avoid sending out emails. |
a24c292 to
61125e5
Compare
4214d8a to
8b4b2b5
Compare
Contributor
|
Build succeeded: |
This was referenced Jan 18, 2022
Closed
This was referenced Jan 18, 2022
This was referenced Jan 19, 2022
This was referenced Jan 24, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously using an opt-in flag to enable span configs; this
commit flips it into an opt-out one. This has the following effects:
for a select few written:
spanconfig dependencies due to circular imports.
We also introduce a more minified form of the opt-out testing flag:
UseSystemConfigSpanForQueues. Using the minified form still enables the
SQL-side of span configs to run (Reconciler, SQLWatcher, SQLTranslator)
but defaults to using the system config span down in KV.
Release note: None