storage: disable BlockPropertyCollectors for SSTWriter#73765
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 14, 2021
Merged
storage: disable BlockPropertyCollectors for SSTWriter#73765craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
There is a todo to enable it for MakeIngestionSSTWriter, which will require plumbing either the cluster version or a reference to the Engine to the function, so one can determine that it is safe to do so. Without this change, tests that mix Pebble old and new versions fail because old versions cannot parse sstable index entries containing block properties. Fixes cockroachdb#73485,cockroachdb#73708 Release note: None
Member
|
This change is |
itsbilal
approved these changes
Dec 13, 2021
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)
Collaborator
Author
|
TFTRs! |
Collaborator
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a todo to enable it for MakeIngestionSSTWriter,
which will require plumbing either the cluster version
or a reference to the Engine to the function, so one can
determine that it is safe to do so.
Without this change, tests that mix Pebble old and new
versions fail because old versions cannot parse sstable
index entries containing block properties.
Fixes #73485,#73708
Release note: None