bazel: introduce a new nonogo config, update dev script#73689
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 10, 2021
Merged
bazel: introduce a new nonogo config, update dev script#73689craig[bot] merged 1 commit intocockroachdb:masterfrom
nonogo config, update dev script#73689craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
jlinder
approved these changes
Dec 10, 2021
Collaborator
jlinder
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
The introduction of `nogo` actually makes building the full `dev` binary rather heavyweight, which vastly increases the surface area of possible build failures. Add a new lightweight `nonogo` config and reference it in an error message so that people can debug their way around the issue. Close cockroachdb#73656. Release note: None
Collaborator
Author
|
bors r=jlinder |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduction of
nogoactually makes building the fulldevbinaryrather heavyweight, which vastly increases the surface area of possible
build failures. Add a new lightweight
nonogoconfig and reference itin an error message so that people can debug their way around the issue.
Close #73656.
Release note: None