Skip to content

kv/kvnemesis: skip TestKVNemesisSingleNode#73525

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:skip-test-TestKVNemesisSingleNode
Dec 6, 2021
Merged

kv/kvnemesis: skip TestKVNemesisSingleNode#73525
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:skip-test-TestKVNemesisSingleNode

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

Refs: #73373

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Refs: cockroachdb#73373

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@irfansharif irfansharif requested a review from a team as a code owner December 6, 2021 18:42
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r+

@irfansharif
Copy link
Copy Markdown
Contributor Author

bors p=9999 r+

@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 6, 2021

Canceled.

@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r+ p=9999

@AlexTalks
Copy link
Copy Markdown
Contributor

@irfansharif if this is related to the ReverseScan issue, perhaps it would be better to simply temporary omit that operation? In generator.go within NewDefaultConfig(), you could disable the operation with the following:

config.Ops.DB.ReverseScan = 0
config.Ops.DB.ReverseScanForUpdate = 0
config.Ops.Batch.Ops.ReverseScan = 0
config.Ops.Batch.Ops.ReverseScanForUpdate = 0
config.Ops.ClosureTxn.TxnClientOps.ReverseScan = 0
config.Ops.ClosureTxn.TxnClientOps.ReverseScanForUpdate = 0
config.Ops.ClosureTxn.TxnBatchOps.Ops.ReverseScan = 0
config.Ops.ClosureTxn.TxnBatchOps.Ops.ReverseScanForUpdate = 0
config.Ops.ClosureTxn.CommitBatchOps.ReverseScan = 0
config.Ops.ClosureTxn.CommitBatchOps.ReverseScanForUpdate = 0

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 6, 2021

Build succeeded:

@craig craig bot merged commit 69b29a5 into cockroachdb:master Dec 6, 2021
@irfansharif irfansharif deleted the skip-test-TestKVNemesisSingleNode branch December 6, 2021 21:55
@irfansharif
Copy link
Copy Markdown
Contributor Author

Oh, woops, sorry didn't see this until now. I'd have happily skipped the specific operation. I forget where we left off -- if the actual fix is forthcoming, might just be worth fixing ReverseScan for good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants