server: remove ad-hoc next-instance-id cache (tenant only)#73523
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 7, 2021
Merged
server: remove ad-hoc next-instance-id cache (tenant only)#73523craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The tenant's cost control code requires a function that retrieves the next live SQL instance ID. The implementation of this function currently caches the value and only refreshes it periodically. This is now unnecessary: cockroachdb#69976 changed the instance reader to use a rangefeed and serve values from memory. Release note: None
Member
|
This change is |
ajwerner
approved these changes
Dec 6, 2021
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rimadeodhar)
rimadeodhar
approved these changes
Dec 7, 2021
Collaborator
rimadeodhar
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
RaduBerinde
commented
Dec 7, 2021
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tenant's cost control code requires a function that retrieves the
next live SQL instance ID. The implementation of this function
currently caches the value and only refreshes it periodically.
This is now unnecessary: #69976 changed the instance reader to use a
rangefeed and serve values from memory.
Release note: None