kvclient: cleanup legacy TxnHeartbeating field#73475
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 6, 2021
Merged
kvclient: cleanup legacy TxnHeartbeating field#73475craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
erikgrinaker
approved these changes
Dec 5, 2021
f867b9b to
5ac9ab9
Compare
This field indicates whether the txn heartbeat loop started. 21.2 is not reading this field; it's only writing it for compatibility with 21.1. So, it's no longer needed since we're working towards 22.1. Release note: None
5ac9ab9 to
14e8619
Compare
andreimatei
commented
Dec 6, 2021
complete! 0 of 0 LGTMs obtained
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This field indicates whether the txn heartbeat loop started. 21.2 is not
reading this field; it's only writing it for compatibility with 21.1.
So, it's no longer needed since we're working towards 22.1.
Release note: None