spanconfig/sqlwatcher: use the right mvcc timestamp#73439
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 6, 2021
Merged
spanconfig/sqlwatcher: use the right mvcc timestamp#73439craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
When unmarshaling descriptor protos into their specific types, we want to pass in the MVCC timestamp at which that descriptor was read. Given we receive these protos through the surrounding rangefeed, we want to use the rangefeed event timestamp. We we erroneously using the timestamp found on the rangefeed event's "previous value", which the API guarantees will be the zero timestamp. (This tripped us up before; we added some commentary + tests in cockroachdb#71225 for the rangefeed library to make this clearer.) Release note: None
Member
|
This change is |
Contributor
Author
|
Verified the fix with just |
arulajmani
approved these changes
Dec 6, 2021
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unmarshaling descriptor protos into their specific types, we want
to pass in the MVCC timestamp at which that descriptor was read. Given
we receive these protos through the surrounding rangefeed, we want to
use the rangefeed event timestamp. We we erroneously using the timestamp
found on the rangefeed event's "previous value", which the API
guarantees will be the zero timestamp.
(This tripped us up before; we added some commentary + tests in #71225
for the rangefeed library to make this clearer.)
Release note: None