kvserver: de-flake TestStrictGCEnforcement#73153
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 26, 2021
Merged
kvserver: de-flake TestStrictGCEnforcement#73153craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
erikgrinaker
approved these changes
Nov 25, 2021
Member
Author
|
bors r=erikgrinaker |
Contributor
|
Merge conflict. |
PR cockroachdb#72978 unintentionally introduced a small change: on a follower read, we would pass the lease status to `checkTSAboveGCThreshold`. If this lease status was `VALID` but not owned by the recipient replica (i.e. this was a follower read), `checkTSAboveGCThreshold` could return the implied GCThreshold (i.e. `now()-gcttl`) instead of the lowest possible TTL. This made `TestStrictGCEnforcement` flaky since that test verifies that a historical read goes through on the recent recipient of a lease (which may not have applied the lease yet), who would serve it via a follower read and would thus error out a read that the test expected to go through. Fixes cockroachdb#73123. Release note: None
f1aab07 to
23a8229
Compare
Member
Author
|
bors r=erikgrinaker |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #72978 unintentionally introduced a small change: on a follower read,
we would pass the lease status to
checkTSAboveGCThreshold. If thislease status was
VALIDbut not owned by the recipient replica (i.e.this was a follower read),
checkTSAboveGCThresholdcould return theimplied GCThreshold (i.e.
now()-gcttl) instead of the lowest possibleTTL. This made
TestStrictGCEnforcementflaky since that test verifiesthat a historical read goes through on the recent recipient of a lease
(which may not have applied the lease yet), who would serve it via a
follower read and would thus error out a read that the test expected to
go through.
Fixes #73123.
Release note: None