release-21.2: roachprod,roachtest: fix mounting on GCP and disable RAID0 in roachtests#72861
Merged
AlexTalks merged 1 commit intorelease-21.2from Nov 17, 2021
Merged
Conversation
Fixes bugs introduced by #72553, which ported support for multiple stores from AWS to GCP. This change fixes the bugs that caused disks mounted to not be written to `/etc/fstab` on GCP instances, causing mounts to go missing on instance restart. Additionally, this change modifies roachtest to default to creating multiple stores on GCP in roachprod invocations rather than mounting a RAID 0 array, thus preserving the existing behavior used in roachtests such as `kv/multi-store-with-overload`. Fixes #72635 Release note: None
Author
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
774ea54 to
adee966
Compare
Member
|
This change is |
This was
linked to
issues
Nov 17, 2021
nicktrav
approved these changes
Nov 17, 2021
This was referenced Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #72803 on behalf of @AlexTalks.
Fixes #72858.
Fixes #72859.
Fixes #72860.
FIxes #72866.
FIxes #72867.
/cc @cockroachdb/release
Fixes bugs introduced by #72553, which ported support for multiple
stores from AWS to GCP. This change fixes the bugs that caused
disks mounted to not be written to
/etc/fstabon GCP instances,causing mounts to go missing on instance restart. Additionally, this
change modifies roachtest to default to creating multiple stores on GCP
in roachprod invocations rather than mounting a RAID 0 array, thus
preserving the existing behavior used in roachtests such as
kv/multi-store-with-overload.Fixes #72635
Release note: None
Release justification: fixes to internal roachtest/roachprod tooling only.