Skip to content

bazel: properly generate .eg.go code in pkg/sql/colconv via bazel#72669

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:remainingeggo
Nov 15, 2021
Merged

bazel: properly generate .eg.go code in pkg/sql/colconv via bazel#72669
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:remainingeggo

Conversation

@rickystewart
Copy link
Copy Markdown
Collaborator

Release note: None

@rickystewart rickystewart requested a review from jlinder November 11, 2021 21:51
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rickystewart rickystewart requested review from rail and removed request for jlinder November 12, 2021 17:13
Copy link
Copy Markdown
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rickystewart)

@rickystewart
Copy link
Copy Markdown
Collaborator Author

bors r=rail

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 15, 2021

Build succeeded:

@craig craig bot merged commit 47a2e2f into cockroachdb:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants