sql: simplify the role option formatting logic#72567
sql: simplify the role option formatting logic#72567craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
c1fd57d to
bbda7e3
Compare
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @knz and @rafiss)
pkg/sql/roleoption/role_option.go, line 97 at r1 (raw file):
"LOGIN": LOGIN, "NOLOGIN": NOLOGIN, "VALID UNTIL": VALIDUNTIL,
@RichardJCai could you confirm that this part of the change is backwards-compatible? i.e., is this string used as a value in system.role_options ?
IIUC this is only for formatting and won't be stored in The part that's written to disk is unchanged here and lives in this map |
rafiss
left a comment
There was a problem hiding this comment.
thanks for confirming, and thanks for this change
Release note: None
bbda7e3 to
d861a35
Compare
|
TFYRs! bors r=rafiss,RichardJCai |
|
Build succeeded: |
Release note: None