Skip to content

protectedts/ptstorage: deflake test#72503

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/deflake-protectedts-test
Nov 8, 2021
Merged

protectedts/ptstorage: deflake test#72503
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/deflake-protectedts-test

Conversation

@ajwerner
Copy link
Copy Markdown
Contributor

@ajwerner ajwerner commented Nov 7, 2021

The test asserted that the error message appeared just once. If there's a retry
the error can appear in the trace more than once. This commit cleans up that
condition.

Fixes #67972

Release note: None

@ajwerner ajwerner requested a review from AlexTalks November 7, 2021 23:09
@ajwerner ajwerner requested a review from a team as a code owner November 7, 2021 23:09
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

The test asserted that the error message appeared just once. If there's a retry
the error can appear in the trace more than once. This commit cleans up that
condition.

Fixes cockroachdb#67972

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/deflake-protectedts-test branch from 485c6c3 to b76d3c5 Compare November 8, 2021 00:53
@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Nov 8, 2021

Unrelated flake. TFTR

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 8, 2021

Build failed:

@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Nov 8, 2021

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 8, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 8, 2021

Build succeeded:

@craig craig bot merged commit fdee50b into cockroachdb:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kv/kvserver/protectedts/ptstorage: TestCorruptData failed

3 participants