sessionphase: fix service latency computation in an error case#72493
sessionphase: fix service latency computation in an error case#72493craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
If we encounter an error during the logical planning, then the end execution phase is never set. Previously, we would use that unset value in order to compute the latency of planning and execution and would get a negative result. This is now fixed. Release note: None
e91f174 to
2257e81
Compare
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Azhng)
|
TFTR! bors r+ |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 2257e81 to blathers/backport-release-21.1-72493: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
If we encounter an error during the logical planning, then the end
execution phase is never set. Previously, we would use that unset value
in order to compute the latency of planning and execution and would get
a negative result. This is now fixed.
Release note: None