roachprod: avoid flaky test due to unused functions#72390
roachprod: avoid flaky test due to unused functions#72390craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @healthy-pod and @rail)
pkg/roachprod/roachprod.go, line 143 at r1 (raw file):
// MaxConcurrency: 32, // } // }
I'd add a var _ = DefaultSyncedCluster instead (that way the code will not rot)
rail
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/roachprod/roachprod.go, line 143 at r1 (raw file):
Previously, RaduBerinde wrote…
I'd add a
var _ = DefaultSyncedClusterinstead (that way the code will not rot)
+1, sounds safer
Merging cockroachdb#71660 trigerred a flaky test due to unused functions. This patch avoids that test by making use of / commenting unused functions. Release note: None
ed53242 to
bbe3b2a
Compare
|
bors r=[RaduBerinde,stevendanna,rail] |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from bbe3b2a to blathers/backport-release-21.1-72390: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.1.x failed. See errors above. error creating merge commit from bbe3b2a to blathers/backport-release-21.2-72390: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
@healthy-pod @RaduBerinde friendly ping - does this still need to be backported? |
|
It was backported as part of #72641. |
Merging #71660 trigerred a flaky test due to unused functions.
This patch avoids that test by making use of / commenting out unused functions.
Release note: None