jobsprotectedts: fixes test failure related to error wrapping#72384
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 3, 2021
Merged
jobsprotectedts: fixes test failure related to error wrapping#72384craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes: cockroachdb#72371 Release note: None
Member
|
This change is |
adityamaru
commented
Nov 3, 2021
| ensureNotExists := func(ctx context.Context, txn *kv.Txn, ptsID uuid.UUID) (err error) { | ||
| _, err = ptp.GetRecord(ctx, txn, ptsID) | ||
| if err == nil { | ||
| return errors.New("found pts record, waiting for ErrNotExists") |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if these should be assertion errors instead? I'm leaning towards no based on my understanding of assertion errors being used when we think a situation is a programmatic error, or violation of an invariant.
Collaborator
There was a problem hiding this comment.
Agreed, this error is expected.
stevendanna
approved these changes
Nov 3, 2021
| ensureNotExists := func(ctx context.Context, txn *kv.Txn, ptsID uuid.UUID) (err error) { | ||
| _, err = ptp.GetRecord(ctx, txn, ptsID) | ||
| if err == nil { | ||
| return errors.New("found pts record, waiting for ErrNotExists") |
Collaborator
There was a problem hiding this comment.
Agreed, this error is expected.
Contributor
Author
|
bors r=stevendanna |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #72371
Release note: None