Skip to content

release-21.2: coldata: fix BenchmarkAppend so that it could be run with multiple count#72253

Merged
craig[bot] merged 1 commit intorelease-21.2from
blathers/backport-release-21.2-72132
Nov 18, 2021
Merged

release-21.2: coldata: fix BenchmarkAppend so that it could be run with multiple count#72253
craig[bot] merged 1 commit intorelease-21.2from
blathers/backport-release-21.2-72132

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl bot commented Oct 29, 2021

Backport 1/1 commits from #72132 on behalf of @yuzefovich.

/cc @cockroachdb/release

Previously, we could get an index out of bounds because we'd allocate
larger Bytes.data slice than int32 offset can support.

Release note: None

Release justification:

@yuzefovich
coldata: fix BenchmarkAppend so that it could be run with multiple count
6670eb6 
Previously, we could get an index out of bounds because we'd allocate
larger `Bytes.data` slice than `int32` offset can support.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 29, 2021 21:41
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-72132 branch from 69b0cad to 6670eb6 Compare October 29, 2021 21:41
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl bot commented Oct 29, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Oct 29, 2021

This change is Reviewable

mgartner
mgartner approved these changes Oct 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 21.2.1.

cucaroach
cucaroach approved these changes Nov 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@cucaroach cucaroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich
Copy link
Copy Markdown
Member

yuzefovich commented Nov 18, 2021

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 18, 2021

Build succeeded:

@craig craig bot merged commit 60e98ab into release-21.2 Nov 18, 2021
@craig craig bot deleted the blathers/backport-release-21.2-72132 branch November 18, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuzefovich yuzefovich Awaiting requested review from yuzefovich

2 more reviewers

@mgartner mgartner mgartner approved these changes

@cucaroach cucaroach cucaroach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yuzefovich yuzefovich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cockroach-teamcity @yuzefovich @mgartner @cucaroach