Skip to content

backup: mark some settings public#71962

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
dt:backup-public-settings
Oct 26, 2021
Merged

backup: mark some settings public#71962
craig[bot] merged 1 commit intocockroachdb:masterfrom
dt:backup-public-settings

Conversation

@dt
Copy link
Copy Markdown
Contributor

@dt dt commented Oct 25, 2021

This marks some of BACKUP's cluster settings as public as they are
intended for user-tuning to match their desired workload / requirements,
such as the delay before invoking priority reads or the target file size.

Release note (ops change): Some existing settings related to BACKUP execution are now listed by SHOW CLUSTER SETTINGS.

Fixes #71786.

@dt dt requested review from a team, adityamaru and katmayb and removed request for a team October 25, 2021 21:23
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@dt dt force-pushed the backup-public-settings branch from 942a029 to 6549bd3 Compare October 25, 2021 21:24
Copy link
Copy Markdown

@katmayb katmayb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David!

This marks some of BACKUP's cluster settings as public as they are
intended for user-tuning to match their desired workload / requirements,
such as the delay before invoking priority reads or the target file size.

Release note (ops change): Some existing settings related to BACKUP execution are now listed  by SHOW CLUSTER SETTINGS.
@dt dt force-pushed the backup-public-settings branch from 6549bd3 to e90a35f Compare October 26, 2021 03:42
@dt
Copy link
Copy Markdown
Contributor Author

dt commented Oct 26, 2021

TFTRs!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 26, 2021

Build succeeded:

@craig craig bot merged commit fa26501 into cockroachdb:master Oct 26, 2021
@dt dt deleted the backup-public-settings branch October 26, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change bulkio.backup.file_size cluster setting to public

4 participants