Skip to content

.github: update CODEOWNERS for roachpb#71919

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
tbg:codeowners=oct-25
Oct 25, 2021
Merged

.github: update CODEOWNERS for roachpb#71919
craig[bot] merged 2 commits intocockroachdb:masterfrom
tbg:codeowners=oct-25

Conversation

@tbg
Copy link
Copy Markdown
Member

@tbg tbg commented Oct 25, 2021

  • codeowners: skip node_modules everywhere
  • .github: tighten CODEOWNERS for roachpb

Release note: None

tbg added 2 commits October 25, 2021 09:38
There are a few more around now and it takes time to walk them.
This around halves how long TestLintEverythingIsOwnedDefaultCodeOwners
takes to run, from ~4s to ~2s, on my Mac.

Release note: None
This is traditionally a KV package but at this point also houses SQL and
Bulk IO code. There was a high volume of errant PR pings, which this
commit tightens up. Whoever creates a new file in `roachpb` will be
asked by the linter to explicitly assign it to a team.

Release note: None
@tbg tbg requested a review from a team as a code owner October 25, 2021 08:21
@tbg tbg requested review from a team and erikgrinaker and removed request for a team October 25, 2021 08:21
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@tbg
Copy link
Copy Markdown
Member Author

tbg commented Oct 25, 2021

bors r=erikgrinaker
TFTR!

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 25, 2021

Build succeeded:

@craig craig bot merged commit 4174c9f into cockroachdb:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants