bazel: skip recompilation when using dev+bazel#71856
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 22, 2021
Merged
bazel: skip recompilation when using dev+bazel#71856craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rickystewart
approved these changes
Oct 22, 2021
.bazelrc
Outdated
| build --symlink_prefix=_bazel/ --ui_event_filters=-DEBUG --define gotags=bazel,crdb_test_off,gss --experimental_proto_descriptor_sets_include_source_info | ||
| test --config=test | ||
| build --symlink_prefix=_bazel/ --ui_event_filters=-DEBUG --define gotags=bazel,crdb_test_off,gss --experimental_proto_descriptor_sets_include_source_info --incompatible_strict_action_env | ||
| test --config=test --incompatible_strict_action_env |
Collaborator
There was a problem hiding this comment.
Is the extra --incompatible_strict_action_env here necessary? I think it should be "inherited" from the line above (tests inherit build flags).
Collaborator
|
Looking forward to switching over to |
Fixes cockroachdb#71835. When switching between using `dev` and `bazel` raw, I kept seeing our C++ protobuf dependency getting recompiled (slowly). It appears that the bazel build for protobuf has a dependency on $PATH (see bazelbuild/intellij#1169 and bazelbuild/bazel#7095). Specifying `--incompatible_strict_action_env` pins PATH and avoids the build cache thrashing we were seeing before. Release note: None
1b47263 to
ff59b0d
Compare
irfansharif
commented
Oct 22, 2021
Contributor
Author
irfansharif
left a comment
There was a problem hiding this comment.
😂 TFTR!
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rickystewart)
.bazelrc, line 4 at r1 (raw file):
Previously, rickystewart (Ricky Stewart) wrote…
Is the extra
--incompatible_strict_action_envhere necessary? I think it should be "inherited" from the line above (tests inheritbuildflags).
TIL, removed.
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71835. When switching between using
devandbazelraw, I keptseeing our C++ protobuf dependency getting recompiled (slowly).
It appears that the bazel build for protobuf has a dependency on $PATH
(see bazelbuild/intellij#1169 and bazelbuild/bazel#7095). Specifying
--incompatible_strict_action_envpins PATH and avoids the build cachethrashing we were seeing before.
Release note: None