kvserver: bump snapshot rates from 8 MB/s to 32 MB/s#71814
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 21, 2021
Merged
kvserver: bump snapshot rates from 8 MB/s to 32 MB/s#71814craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
nvb
approved these changes
Oct 21, 2021
eec0d75 to
e559012
Compare
For years we've found these rates to be too conservative, and the bottleneck during recovery/replication. We have customers running at much higher rates (128 MB/s) for production clusters. Let's bump these default and let it bake over the release to see what breaks. Release note: The default snapshot recovery/rebalance rates `kv.snapshot_rebalance.max_rate` and `kv.snapshot_recovery.max_rate` were bumped from 8MB/s to 32MB/s, production experience has taught us that earlier values were too conservative. Users might observer higher network utilization during rebalancing/recovery in service of rebalancing/recovering faster (for the latter, possibly reducing the MTTF). If the extra utilization is undesirable, users can manually revert these rates back to their original settings of 8 MB/s.
e559012 to
c6f21af
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This was referenced Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For years we've found these rates to be too conservative, and the
bottleneck during recovery/replication. We have customers running at
much higher rates (128 MB/s) for production clusters. Let's bump these
default and let it bake over the release to see what breaks.
Release note: The default snapshot recovery/rebalance rates
kv.snapshot_rebalance.max_rateandkv.snapshot_recovery.max_ratewere bumped from 8MB/s to 32MB/s, production experience has taught us
that earlier values were too conservative. Users might observer higher
network utilization during rebalancing/recovery in service of
rebalancing/recovering faster (for the latter, possibly reducing the
MTTF). If the extra utilization is undesirable, users can manually
revert these rates back to their original settings of 8 MB/s.