[wip] migrations,server: allow tests to override minimum supported version#71686
Closed
irfansharif wants to merge 2 commits intocockroachdb:masterfrom
Closed
[wip] migrations,server: allow tests to override minimum supported version#71686irfansharif wants to merge 2 commits intocockroachdb:masterfrom
irfansharif wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Makes for a more helpful error message in cockroachdb#69828; there we're dealing with tests that override the binary version that now fail seeing as how the min supported version is advanced. Release note: None
…rsion
Certain tests override the binary version (for e.g. in order to test the
execution of a specific migration association with a specific cluster
version). For these tests we also want to bypass the bootstrap ("is too
old for running version") version check, especially as we bump the
minimum supported version past a bunch of cluster versions that were
introduced in the last release cycle (cockroachdb#69828).
We could technically delete all the past-release cluster version
handling code before introducing next release development versions,
but it's easy to keep it around to simplify backports (and also it's a
lot of code to get rid of, only to allow next-release versions to be
added). Allowing these tests to override the minimum supported
version is a convenient workaround.
---
This commit updates one of the many failing tests blocking cockroachdb#69828, but
not all of them. The approach in this commit of providing a sister testing
knob `BinaryMinSupportedVersion` might not be sufficient due to
interactions with the cluster version setting (see comments on cockroachdb#69828).
It's possible we want to go all the way and all tests to install a
clusterversion.Handle instead. Leaving this PR up for posterity.
Release note: None
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain tests override the binary version (for e.g. in order to test the
execution of a specific migration association with a specific cluster
version). For these tests we also want to bypass the bootstrap ("is too
old for running version") version check, especially as we bump the
minimum supported version past a bunch of cluster versions that were
introduced in the last release cycle (#69828).
We could technically delete all the past-release cluster version
handling code before introducing next release development versions,
but it's easy to keep it around to simplify backports (and also it's a
lot of code to get rid of, only to allow next-release versions to be
added). Allowing these tests to override the minimum supported
version is a convenient workaround.
This commit updates one of the many failing tests blocking #69828, but
not all of them. The approach in this commit of providing a sister testing
knob
BinaryMinSupportedVersionmight not be sufficient due tointeractions with the cluster version setting (see comments on #69828).
It's possible we want to go all the way and all tests to install a
clusterversion.Handle instead. Leaving this PR up for posterity.
Release note: None