Skip to content

server: add assertion around binary versions#71684

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:211018.assert-binary-ver-override
Oct 19, 2021
Merged

server: add assertion around binary versions#71684
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:211018.assert-binary-ver-override

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

Makes for a more helpful error message in #69828; there we're dealing
with tests that override the binary version that now fail seeing as how
the min supported version is advanced.

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Makes for a more helpful error message in cockroachdb#69828; there we're dealing
with tests that override the binary version that now fail seeing as how
the min supported version is advanced.

Release note: None
@irfansharif irfansharif force-pushed the 211018.assert-binary-ver-override branch from 0f068c7 to 475a110 Compare October 19, 2021 02:25
@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 19, 2021

Build succeeded:

@craig craig bot merged commit 0e2e645 into cockroachdb:master Oct 19, 2021
@irfansharif irfansharif deleted the 211018.assert-binary-ver-override branch October 19, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants