licenses: Update BSL change date for master/22.1#71613
licenses: Update BSL change date for master/22.1#71613craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
df794de to
1b85624
Compare
jlinder
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @bdarnell and @celiala)
licenses/BSL.txt, line 18 at r1 (raw file):
controlled by such third parties. Change Date: 2025-04-01
Should this be 2025-04-01 or 2025-05-01? i.e., do we do it for 3 years to the month the release is made in (we've been releasing in May, not April)?
bdarnell
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
licenses/BSL.txt, line 7 at r1 (raw file):
Licensor: Cockroach Labs, Inc. Licensed Work: CockroachDB 22.1 The Licensed Work is (c) 2021 Cockroach Labs, Inc.
In the past we've updated the copyright year here to reflect the eventual release date (as in 186a625#diff-d20ea444c3b8b7b72100cc0990127b6e7785c6103e57d4c6e6eb25c96d525539). If we don't do it now we need to make sure it's on a checklist for the start of the new year.
licenses/BSL.txt, line 18 at r1 (raw file):
Previously, jlinder (James H. Linder) wrote…
Should this be
2025-04-01or2025-05-01? i.e., do we do it for 3 years to the month the release is made in (we've been releasing in May, not April)?
This doesn't need to be strictly tied to the release (i.e. there's no commitment anywhere that the change is three years from the release date. There is a commitment in the text of the BSL that the change date is no more than four years in the future).
I'd be inclined to just keep flipping back and forth between 04-01 and 10-01 change dates for consistency, but it would also be fine to make a better guess at the final release date if we wanted to (and it's fine if that guess is off in either direction).
This commit updates the BSL license for master/22.1 (non-production code change). Release note: None
1b85624 to
42a219f
Compare
celiala
left a comment
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
TFTRs!
licenses/BSL.txt, line 7 at r1 (raw file):
Previously, bdarnell (Ben Darnell) wrote…
In the past we've updated the copyright year here to reflect the eventual release date (as in 186a625#diff-d20ea444c3b8b7b72100cc0990127b6e7785c6103e57d4c6e6eb25c96d525539). If we don't do it now we need to make sure it's on a checklist for the start of the new year.
Ack:
- Updated the copyright year to 2022
- Made a note in the docs / tracking issue (#70751), saying that the copyright year needs to be updated
licenses/BSL.txt, line 18 at r1 (raw file):
Previously, bdarnell (Ben Darnell) wrote…
This doesn't need to be strictly tied to the release (i.e. there's no commitment anywhere that the change is three years from the release date. There is a commitment in the text of the BSL that the change date is no more than four years in the future).
I'd be inclined to just keep flipping back and forth between 04-01 and 10-01 change dates for consistency, but it would also be fine to make a better guess at the final release date if we wanted to (and it's fine if that guess is off in either direction).
Ack:
- I've updated the docs to default to flip between 04-01 and 10-01
- Added your additional context in case we want to adjust this to a better guess in the future (will context will be helpful as we move towards more frequent releases)
|
TFTRs! bors r+ |
|
Build succeeded: |
This commit updates the BSL license for master/22.1
(non-production code change).